Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added lhn-backbutton #44753

Closed
wants to merge 6 commits into from
Closed

added lhn-backbutton #44753

wants to merge 6 commits into from

Conversation

Taiwrash
Copy link

@Taiwrash Taiwrash commented Jul 3, 2024

Details

  • Fixes the LHN button to redirect to the right slugs when the back button is clicked. I updated the navigateBack function.

Fixed Issues

PROPOSAL:
$ #42600
$ #42600 (comment)

Tests

  • Click the back button and it works
  • Try the two slugs currently available and it works
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screen.Recording.2024-07-03.at.01.03.53.mov

@Taiwrash Taiwrash requested review from a team as code owners July 3, 2024 00:10
@melvin-bot melvin-bot bot requested review from rushatgabhane and removed request for a team July 3, 2024 00:10
Copy link

melvin-bot bot commented Jul 3, 2024

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@dubielzyk-expensify
Copy link
Contributor

I've been OOO so might have missed something but this recording seems wrong to me. If you navigate to:
Expensify Classic > Chat > Edit or delete messages then click Back, to me it shouldn't take me back to Expensify Classic.

Instead I'd expect back to show the previous page and LHN which in this instance would be Chat.

Unless I'm very confused. cc @Expensify/design

@rushatgabhane
Copy link
Member

@dubielzyk-expensify yeah that's right it should take you to the hub

@rushatgabhane
Copy link
Member

@Taiwrash please fix it

@shawnborton
Copy link
Contributor

Totally agree @dubielzyk-expensify - I feel like I had similar comments about this back button behavior elsewhere, I can't remember where though.

@shawnborton
Copy link
Contributor

Ah yes, @Taiwrash please take another look at the comments I had on your closed PR here.

@Taiwrash
Copy link
Author

Taiwrash commented Jul 3, 2024

Oh! I can't actually remember where exactly I got the suggestion to make it the way I did before.

Below is the update made

  • When you go to Expensify Classic > Chat > Edit or delete messages then click Back, it will show the previous page and LHN which in this instance would be Chat

See below

Screen.Recording.2024-07-03.at.07.32.02.mov

@shawnborton
Copy link
Contributor

I think that seems better, thanks!

@Taiwrash
Copy link
Author

Taiwrash commented Jul 5, 2024

Hello everyone, I am still awaiting our feedback to merge this @rushatgabhane @dubielzyk-expensify @shawnborton

@dubielzyk-expensify
Copy link
Contributor

That looks good to me too. Can you confirm that the same back behaviour also happens with the back button on the browser?

@Taiwrash
Copy link
Author

Taiwrash commented Jul 7, 2024

Here is the demo showing the browser back button

Screen.Recording.2024-07-07.at.01.29.14.mov

@shawnborton
Copy link
Contributor

That looks and feels pretty good to me.

.gitconfig Outdated Show resolved Hide resolved
docs/Gemfile.lock Outdated Show resolved Hide resolved
docs/assets/js/main.js Outdated Show resolved Hide resolved
docs/assets/js/main.js Outdated Show resolved Hide resolved
docs/assets/js/main.js Outdated Show resolved Hide resolved
@Taiwrash
Copy link
Author

Taiwrash commented Jul 8, 2024

@rushatgabhane all corrections made

@Taiwrash
Copy link
Author

Looking forward to the next review @rushatgabhane @shawnborton @dubielzyk-expensify @r8

docs/Gemfile.lock Outdated Show resolved Hide resolved
docs/_layouts/default.html Outdated Show resolved Hide resolved
docs/assets/js/main.js Outdated Show resolved Hide resolved
@Taiwrash
Copy link
Author

@rushatgabhane just fixed all

@Taiwrash
Copy link
Author

Still await the final review for this, I want to pick another issue to work on

@Taiwrash
Copy link
Author

@rushatgabhane @dubielzyk-expensify @r8 when is the next review please?

@@ -49,27 +49,41 @@ function isInRange(num, min, max) {
* If a page is directly accessed (e.g., via deep link, bookmark, or opened in a new tab),the user will be navigated
* back to the relevant hub page of that article.
*/
function navigateBack() {
const currentHost = window.location.host;
const referrer = document.referrer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Taiwrash do you know why this code was removed?

Copy link
Member

@rushatgabhane rushatgabhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Taiwrash bug 1: clicking any item in LHN takes you back

Screen.Recording.2024-07-23.at.04.05.56.mov

Copy link
Member

@rushatgabhane rushatgabhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug 2: if you click back from LHN, you can't go forward using browser forward button

@rushatgabhane
Copy link
Member

@Taiwrash were you able to fix the bugs?

@shawnborton
Copy link
Contributor

What's the latest on this one?

@shawnborton
Copy link
Contributor

Friendly bump, do we close this one or are we still doing it?

@rushatgabhane
Copy link
Member

rushatgabhane commented Sep 15, 2024

@shawnborton we can close this PR. This was completed by another contributor in another PR

@dannymcclain from design reviewed it

@shawnborton
Copy link
Contributor

Sounds good, will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants